lkml.org 
[lkml]   [2017]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 76/78] ALSA: hda - Clear the leftover component assignment at snd_hdac_i915_exit()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit faafd03d23c913633d2ef7e6ffebdce01b164409 upstream.

    The commit [d745f5e7b8b2: ALSA: hda - Add the pin / port mapping on
    Intel ILK and VLV] introduced a WARN_ON() to check the pointer for
    avoiding the double initializations. But hdac_acomp pointer wasn't
    cleared at snd_hdac_i915_exit(), thus after reloading the HD-audio
    driver, it may result in the false positive warning. This patch makes
    sure to clear the leftover pointer at exit.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94736
    Reported-by: Daniela Doras-prodan <daniela.doras-prodan@intel.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Cc: Kouta Okamoto <kouta.okamoto@toshiba.co.jp>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/hda/hdac_i915.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/sound/hda/hdac_i915.c
    +++ b/sound/hda/hdac_i915.c
    @@ -273,6 +273,7 @@ int snd_hdac_i915_exit(struct hdac_bus *

    kfree(acomp);
    bus->audio_component = NULL;
    + hdac_acomp = NULL;

    return 0;
    }

    \
     
     \ /
      Last update: 2017-12-22 11:33    [W:4.071 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site