Messages in this thread | | | Date | Thu, 21 Dec 2017 13:38:53 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm: Fix the driver cleanup code |
| |
On Thu, Dec 21, 2017 at 08:31:14PM +0000, Shaikh, Azhar wrote:
> Yes I thought about it too. But if some other chip->ops function in > future, which *might* be in this same case, hence for that > introduced this flag.
It can't be - the ops struct is constant, can't be modified, and tpm_tis_core controls what is set. If someone future person meddles in this then they can fix here to.
Recommend a short comment in the ops clk_enale initializer and call direct?
Jason
| |