lkml.org 
[lkml]   [2017]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] dt-bindings: ti-sysc: Update binding for timers and capabilities
* Rob Herring <robh@kernel.org> [171220 18:13]:
> On Sat, Dec 16, 2017 at 11:22:22AM -0800, Tony Lindgren wrote:
> > I was planning to have "ti,sysc-delay-us" only in the driver, but
> > the same IP needs it set on dm814x while not on omap4 for OTG
> > for example. I could add SoC specific quirks to the driver
> > for that one if you prefer that instead?
>
> No, I don't have a preference.

OK

> > > Are the bits you've defined all of them or there's more?
> >
> > That's it, with this binding I've allocated the data from dts
> > for the tests I've done. So that should allow us to replace the
> > static data to start with as seen with the following command:
> >
> > $ git grep -A10 "struct omap_hwmod_class_sysconfig" \
> > arch/arm/*hwmod*data*.c
> > ...
> >
> > So that's to configure a big pile of different module
> > configurations we currently have as can be seen with:
> >
> > $ git grep "struct omap_hwmod_class_sysconfig" \
> > arch/arm/*hwmod*data*.c | wc -l
> > 194
> >
> > I'm sure there's still few duplicates there though..
>
> Okay, then I guess I'm okay with this.
>
> Reviewed-by: Rob Herring <robh@kernel.org>

OK thanks for the review.

Regards,

Tony

\
 
 \ /
  Last update: 2017-12-21 16:30    [W:2.411 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site