lkml.org 
[lkml]   [2017]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v16 0/5] ZII RAVE platform driver
On Wed, Dec 20, 2017 at 1:51 PM, Philippe Ombredanne
<pombredanne@nexb.com> wrote:
> Andrey,
>
> On Wed, Dec 20, 2017 at 9:45 PM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>> Everyone:
>>
>> This patch series is v16 of the driver for supervisory processor found
>> on RAVE series of devices from ZII. Supervisory processor is a PIC
>> microcontroller connected to various electrical subsystems on RAVE
>> devices whose firmware implements protocol to command/qery them.
>>
>> NOTE:
>>
>> * This driver dependends on crc_ccitt_false(), added by
>> 2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch
>> was pulled in by Andrew Morton and is currently avaiting users, so
>> this series might have to go in through Andrew's tree
>>
>> Changes since [v15]:
>>
>> - Adopted SPDX tags for licensing information per Philippe's
>> request
>
> Thank you for using the SPDX tags: you have my cheerful ack for the
> SPDX tags for the whole patch set
>
> There is one minor problem though: your comment style for the SPDX tag
> lines. Check Thomas doc patches and Linus comments on this topic: you
> should use // C++ style commnent in .c files and /* */ C-style
> comments in .h files.
>
> e.g. do not use this for a .c file:
>
>> +++ b/drivers/watchdog/rave-sp-wdt.c
>> @@ -0,0 +1,337 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>
> But this instead:
>
>> +++ b/drivers/watchdog/rave-sp-wdt.c
>> @@ -0,0 +1,337 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>
>
> Acked-by: Philippe Ombredanne <pombredanne@nexB.com>
>

OK, good to know, will fix in v17 soon.

Thanks,
Andrey Smirnov

\
 
 \ /
  Last update: 2017-12-21 01:20    [W:0.207 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site