lkml.org 
[lkml]   [2017]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 1/3] lib: Add strongly typed 64bit int_sqrt
From
Date
On Wed, 2017-12-20 at 10:33 +0100, Crt Mori wrote:
> There is no option to perform 64bit integer sqrt on 32bit platform.
> Added stronger typed int_sqrt64 enables the 64bit calculations to
> be performed on 32bit platforms. Although int_sqrt() is a rough
> approximation, the same algorithm is used in int_sqrt64() as good
> enough on 32bit platform.
[]
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
[]
> @@ -459,6 +459,7 @@ extern int kernel_text_address(unsigned long addr);
> extern int func_ptr_is_kernel_text(void *ptr);
>
> unsigned long int_sqrt(unsigned long);
> +u32 int_sqrt64(u64 x);

#ifdef BITS_PER_LONG == 64
static inline u32 int_sqrt64(u64 x)
{
re
turn (u32)int_sqrt(x);
}
#else
u32 int_sqrt64(u64 x);
#endif

[]

> +#if BITS_PER_LONG < 64
> +/**
> + * int_sqrt64 - strongly typed int_sqrt function when minimum 64 bit input
> + * is expected.
> + * @x: 64bit integer of which to calculate the sqrt
> + */
> +u32 int_sqrt64(u64 x)
> +{
> + u64 b, m, y = 0;
> +
> + if (x <= 1)
> + return x;
> +
> + m = 1ULL << (fls64(x) & ~1ULL);
> + while (m != 0) {
> + b = y + m;
> + y >>= 1;
> +
> + if (x >= b) {
> + x -= b;
> + y += m;
> + }
> + m >>= 2;
> + }
> +
> + return y;
> +}
> +EXPORT_SYMBOL(int_sqrt64);
> +#else
> +u32 int_sqrt64(u64 x)
> +{
> + return int_sqrt(x);
> +}
> +EXPORT_SYMBOL(int_sqrt64);
> +#endif

This doesn't need to be EXPORT_SYMBOL for the
BITS_PER_LONG == 64 case

\
 
 \ /
  Last update: 2017-12-20 10:57    [W:0.035 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site