lkml.org 
[lkml]   [2017]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/4] gpio: sysfs: don't use sprintf() for 'value' attribute
On Mon, Dec 18, 2017 at 11:08 AM, Christophe Leroy
<christophe.leroy@c-s.fr> wrote:

> A bench with 'perf record' shows that most of time spent in value_show()
> is spent in sprintf()
>
> --42.41%--sysfs_kf_read
> |
> |--39.73%--dev_attr_show
> | |
> | |--38.23%--value_show
> | | |
> | | |--29.22%--sprintf
> | | |
> | | |--2.94%--gpiod_get_value_cansleep
> | | |
>
> value_show() only returns "0\n" or "1\n", therefore the use of
> sprintf() can be avoided
>
> With this patch we get the following result with 'perf record'
>
> --13.89%--sysfs_kf_read
> |
> |--10.72%--dev_attr_show
> | |
> | |--9.44%--value_show
> | | |
> | | |--4.61%--gpiod_get_value_cansleep
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

Patch applied.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2017-12-20 10:34    [W:0.142 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site