lkml.org 
[lkml]   [2017]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/11] ARM: OMAP1: constify gpio_led
    Date
    gpio_led are not supposed to change at runtime.
    struct gpio_led_platform_data working with const gpio_led
    provided by <linux/leds.h>. So mark the non-const structs
    as const.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    arch/arm/mach-omap1/board-h2.c | 2 +-
    arch/arm/mach-omap1/board-h3.c | 2 +-
    arch/arm/mach-omap1/board-htcherald.c | 2 +-
    arch/arm/mach-omap1/board-osk.c | 4 ++--
    4 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c
    index ab51f85..43f95e5 100644
    --- a/arch/arm/mach-omap1/board-h2.c
    +++ b/arch/arm/mach-omap1/board-h2.c
    @@ -274,7 +274,7 @@ static int h2_nand_dev_ready(struct mtd_info *mtd)
    .resource = h2_kp_resources,
    };

    -static struct gpio_led h2_gpio_led_pins[] = {
    +static const struct gpio_led h2_gpio_led_pins[] __initconst = {
    {
    .name = "h2:red",
    .default_trigger = "heartbeat",
    diff --git a/arch/arm/mach-omap1/board-h3.c b/arch/arm/mach-omap1/board-h3.c
    index ad339f5..957edb5 100644
    --- a/arch/arm/mach-omap1/board-h3.c
    +++ b/arch/arm/mach-omap1/board-h3.c
    @@ -326,7 +326,7 @@ static void __init h3_init_smc91x(void)
    },
    };

    -static struct gpio_led h3_gpio_led_pins[] = {
    +static const struct gpio_led h3_gpio_led_pins[] __initconst = {
    {
    .name = "h3:red",
    .default_trigger = "heartbeat",
    diff --git a/arch/arm/mach-omap1/board-htcherald.c b/arch/arm/mach-omap1/board-htcherald.c
    index 67d4669..627b5e3 100644
    --- a/arch/arm/mach-omap1/board-htcherald.c
    +++ b/arch/arm/mach-omap1/board-htcherald.c
    @@ -292,7 +292,7 @@
    };

    /* LEDs for the Herald. These connect to the HTCPLD GPIO device. */
    -static struct gpio_led gpio_leds[] = {
    +static const struct gpio_led gpio_leds[] __initconst = {
    {"dpad", NULL, HTCPLD_GPIO_LED_DPAD, 0, 0, LEDS_GPIO_DEFSTATE_OFF},
    {"kbd", NULL, HTCPLD_GPIO_LED_KBD, 0, 0, LEDS_GPIO_DEFSTATE_OFF},
    {"vibrate", NULL, HTCPLD_GPIO_LED_VIBRATE, 0, 0, LEDS_GPIO_DEFSTATE_OFF},
    diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c
    index c66372e..4216b50 100644
    --- a/arch/arm/mach-omap1/board-osk.c
    +++ b/arch/arm/mach-omap1/board-osk.c
    @@ -167,7 +167,7 @@
    &osk5912_cf_device,
    };

    -static struct gpio_led tps_leds[] = {
    +static const struct gpio_led tps_leds[] __initconst = {
    /* NOTE: D9 and D2 have hardware blink support.
    * Also, D9 requires non-battery power.
    */
    @@ -385,7 +385,7 @@ static void __init osk_init_cf(void)
    .id = -1,
    };

    -static struct gpio_led mistral_gpio_led_pins[] = {
    +static const struct gpio_led mistral_gpio_led_pins[] __initconst = {
    {
    .name = "mistral:red",
    .default_trigger = "heartbeat",
    --
    1.9.1
    \
     
     \ /
      Last update: 2017-12-20 09:50    [W:4.379 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site