lkml.org 
[lkml]   [2017]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation()
On Sat, Dec 02, 2017 at 12:32:20PM +0200, Marcus Wolf wrote:
> Defines used in cases contain already shifted bits, so currentValue must not be shifted.

Please properly wrap your changelog text.

And you need a blank line before your signed-off-by line.

> signed_of_by: Marcus Wolf <linux@wolf-entwicklungen.de>

"Signed-off-by:"

Did you run scripts/checkpatch.pl on your patch?

You sent 4 patches just now, which order should I apply them in? I have
no idea, so please fix them up and resend them as a numbered patch
series so that I have a chance to get it right.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-12-02 16:46    [W:2.017 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site