Messages in this thread | | | From | Linus Walleij <> | Date | Sat, 2 Dec 2017 16:30:08 +0100 | Subject | Re: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking |
| |
Hi Arvind,
thanks for the patch!
On Thu, Nov 30, 2017 at 3:12 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> (...) > irq = platform_get_irq(pdev, 0); > - if (!irq) > - return -EINVAL; > + if (irq < 0) > + return irq;
This is wrong. For an in-depth explanation why irq 0 in not valid, see: https://lwn.net/Articles/470820/
It should be:
if (irq <= 0) return irq ? irq : -EINVAL;
Please update and resubmit. If you have more patches like this, correct them too.
Yours, Linus Walleij
| |