lkml.org 
[lkml]   [2017]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking
Hi Arvind,

thanks for the patch!

On Thu, Nov 30, 2017 at 3:12 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
(...)
> irq = platform_get_irq(pdev, 0);
> - if (!irq)
> - return -EINVAL;
> + if (irq < 0)
> + return irq;

This is wrong.
For an in-depth explanation why irq 0 in not valid, see:
https://lwn.net/Articles/470820/

It should be:

if (irq <= 0)
return irq ? irq : -EINVAL;

Please update and resubmit. If you have more patches like this,
correct them too.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2017-12-02 16:30    [W:0.039 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site