Messages in this thread | | | From | "Zhang, Sean C. (NSB - CN/Hangzhou)" <> | Subject | RE: [Bug fix] octeon-i2c driver improvement [2/2] | Date | Tue, 19 Dec 2017 05:25:49 +0000 |
| |
Hi Jan and David,
Any other comment for these three patches? I sent them separately. 1. [Bug fix] octeon-i2c driver updates 2. [Bug fix] octeon-i2c driver improvement [1/2] 3. [Bug fix] octeon-i2c driver improvement [2/2]
BR, Sean Zhang
-----Original Message----- From: Zhang, Sean C. (NSB - CN/Hangzhou) Sent: Wednesday, December 06, 2017 5:51 PM To: 'David Daney' <ddaney@caviumnetworks.com>; 'Jan Glauber' <jan.glauber@caviumnetworks.com>; 'david.daney@cavium.com' <david.daney@cavium.com> Cc: 'wsa@the-dreams.de' <wsa@the-dreams.de>; 'linux-i2c@vger.kernel.org' <linux-i2c@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux-kernel@vger.kernel.org> Subject: [Bug fix] octeon-i2c driver improvement [2/2]
Hi Jan and David,
For octeon-i2c driver, there has duplicated interrupt disable in octeon_i2c_isr(), octeon_i2c_hlc_wait() and octeon_i2c_wait(), since octeon_i2c_hlc_wait() and octeon_i2c_wait() has pair of interrupt enable and disable, so the interrupt disable in octeon_i2c_isr() is not necessary. attached patch removed this unnecessary interrupt disable step.
Please have time to review it. Thanks.
BR Sean Zhang
| |