lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] mfd: syscon: Add hardware spinlock support
On Tue, Dec 19, 2017 at 02:55:47PM +0800, Baolin Wang wrote:

> Um, why regmap doesn't accept a zero lock-id, that because regmap will
> reguest hwlock depending on the 'regmap_config->hwlock_id' is not
> zero, if regmap regard a zero lock-id as valid which will affect other
> 'struct regmap_config' definition. So users should not assign the zero
> lock-id to regmap.

> Now of_hwspin_lock_get_id() can return 0 as valid, which depend on
> what is the base id registered by hwspinlock driver. So you think we
> should not regard 0 as valid from of_hwspin_lock_get_id(), I can try
> to send another patch to fix.

If 0 is a valid hwspinlock ID you need to add a flag to the regmap
config to say if a hwspinlock should be used. That way we're not
rejecting valid values.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-12-19 10:22    [W:0.078 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site