Messages in this thread | | | Date | Tue, 19 Dec 2017 09:59:50 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v4 05/15] drm/sun4i: Fix error path handling |
| |
On Thu, Dec 07, 2017 at 04:58:50PM +0100, Maxime Ripard wrote: > The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap > initialization sequence") moved a bunch of logic around, but forgot to > update the gotos after the introduction of the err_free_dotclock label. > > It means that if we fail later that the one introduced in that commit, > we'll just to the old label which isn't free the clock we created. This > will result in a breakage as soon as someone tries to do something with > that clock, since its resources will have been long reclaimed. > > Cc: <stable@vger.kernel.org> > Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied this one as a fix. Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |