Messages in this thread | | | From | Joel Stanley <> | Date | Wed, 20 Dec 2017 13:52:36 +1030 | Subject | Re: [PATCH v2 18/19] ARM: dts: aspeed-romulus: Update Romulus system |
| |
On Mon, Dec 18, 2017 at 8:02 PM, Cédric Le Goater <clg@kaod.org> wrote: >> +}; >> + >> +&fmc { >> + status = "okay"; >> + >> + flash@0 { >> + status = "okay"; >> + label = "pnor"; >> + m25p,fast-read; >> +#include "openbmc-flash-layout.dtsi" >> + }; >> +}; >> + >> +&spi1 { >> + status = "okay"; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_spi1_default>; >> + >> + flash@0 { >> + status = "okay"; >> + label = "pnor"; >> + m25p,fast-read; >> }; >> }; > > > hmm, the fmc and spi1 bindings were already added in commit 1142aea9ff9d. > > >> @@ -38,6 +101,7 @@ >> status = "okay"; >> m25p,fast-read; >> label = "bmc"; >> +#include "openbmc-flash-layout.dtsi" > > > This looks like an extra "fmc" node ?
You're right. It still built and booted too. Good catch.
Cheers,
Joel
| |