lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 013/178] USB: uas and storage: Add US_FL_BROKEN_FUA for another JMicron JMS567 ID
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Kozub <zub@linux.fjfi.cvut.cz>

    commit 62354454625741f0569c2cbe45b2d192f8fd258e upstream.

    There is another JMS567-based USB3 UAS enclosure (152d:0578) that fails
    with the following error:

    [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
    [sda] tag#0 Sense Key : Illegal Request [current]
    [sda] tag#0 Add. Sense: Invalid field in cdb

    The issue occurs both with UAS (occasionally) and mass storage
    (immediately after mounting a FS on a disk in the enclosure).

    Enabling US_FL_BROKEN_FUA quirk solves this issue.

    This patch adds an UNUSUAL_DEV with US_FL_BROKEN_FUA for the enclosure
    for both UAS and mass storage.

    Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/storage/unusual_devs.h | 7 +++++++
    drivers/usb/storage/unusual_uas.h | 7 +++++++
    2 files changed, 14 insertions(+)

    --- a/drivers/usb/storage/unusual_devs.h
    +++ b/drivers/usb/storage/unusual_devs.h
    @@ -2113,6 +2113,13 @@ UNUSUAL_DEV( 0x152d, 0x0567, 0x0114, 0x
    USB_SC_DEVICE, USB_PR_DEVICE, NULL,
    US_FL_BROKEN_FUA ),

    +/* Reported by David Kozub <zub@linux.fjfi.cvut.cz> */
    +UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
    + "JMicron",
    + "JMS567",
    + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
    + US_FL_BROKEN_FUA),
    +
    /*
    * Reported by Alexandre Oliva <oliva@lsd.ic.unicamp.br>
    * JMicron responds to USN and several other SCSI ioctls with a
    --- a/drivers/usb/storage/unusual_uas.h
    +++ b/drivers/usb/storage/unusual_uas.h
    @@ -142,6 +142,13 @@ UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x99
    USB_SC_DEVICE, USB_PR_DEVICE, NULL,
    US_FL_BROKEN_FUA | US_FL_NO_REPORT_OPCODES),

    +/* Reported-by: David Kozub <zub@linux.fjfi.cvut.cz> */
    +UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
    + "JMicron",
    + "JMS567",
    + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
    + US_FL_BROKEN_FUA),
    +
    /* Reported-by: Hans de Goede <hdegoede@redhat.com> */
    UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
    "VIA",

    \
     
     \ /
      Last update: 2017-12-18 17:59    [W:2.958 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site