Messages in this thread | | | Date | Mon, 18 Dec 2017 13:44:30 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH] ARM: B15: fix unused label warnings |
| |
On Mon, Dec 18, 2017 at 02:41:11PM +0100, Arnd Bergmann wrote: > The new conditionally compiled code leaves some labels and one > variable unreferenced when CONFIG_HOTPLUG_CPU and CONFIG_PM_SLEEP > are disabled: > > arch/arm/mm/cache-b15-rac.c: In function 'b15_rac_init': > arch/arm/mm/cache-b15-rac.c:353:1: error: label 'out_unmap' defined but not used [-Werror=unused-label] > out_unmap: > ^~~~~~~~~ > arch/arm/mm/cache-b15-rac.c:351:1: error: label 'out_cpu_dead' defined but not used [-Werror=unused-label] > out_cpu_dead: > ^~~~~~~~~~~~ > At top level: > arch/arm/mm/cache-b15-rac.c:53:12: error: 'rac_config0_reg' defined but not used [-Werror=unused-variable] > > This adds more #ifdefs around them. > > Fixes: 55de88778f4b ("ARM: 8726/1: B15: Add CPU hotplug awareness") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > Florian, if this looks good to you, please forward the fix into Russell's > patch tracker, otherwise just send a better fix.
I'd prefer a better fix than yet more ifdefs...
-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
| |