lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 16/69] NFSD: fix nfsd_minorversion(.., NFSD_AVAIL)
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: NeilBrown <neilb@suse.com>


    [ Upstream commit 928c6fb3a9bfd6c5b287aa3465226add551c13c0 ]

    Current code will return 1 if the version is supported,
    and -1 if it isn't.
    This is confusing and inconsistent with the one place where this
    is used.
    So change to return 1 if it is supported, and zero if not.
    i.e. an error is never returned.

    Signed-off-by: NeilBrown <neilb@suse.com>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/nfsd/nfssvc.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/fs/nfsd/nfssvc.c
    +++ b/fs/nfsd/nfssvc.c
    @@ -150,7 +150,8 @@ int nfsd_vers(int vers, enum vers_op cha

    int nfsd_minorversion(u32 minorversion, enum vers_op change)
    {
    - if (minorversion > NFSD_SUPPORTED_MINOR_VERSION)
    + if (minorversion > NFSD_SUPPORTED_MINOR_VERSION &&
    + change != NFSD_AVAIL)
    return -1;
    switch(change) {
    case NFSD_SET:

    \
     
     \ /
      Last update: 2017-12-18 19:37    [W:3.837 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site