lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 053/177] irqchip/mvebu-odmi: Select GENERIC_MSI_IRQ_DOMAIN
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>


    [ Upstream commit fa23b9d1b89fdc34f296f02e496a20aeff5736be ]

    This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we
    may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled:

    drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has initializer but incomplete type
    static struct msi_domain_ops odmi_msi_ops = {
    ^~~~~~~~~~~~~~
    drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable 'odmi_msi_domain_info' has initializer but incomplete type
    static struct msi_domain_info odmi_msi_domain_info = {
    ^~~~~~~~~~~~~~~
    drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has no member named 'flags'
    .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
    ^~~~~
    drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS' undeclared here (not in a function)
    .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
    ^~~~~~~~~~~~~~~~~~~~~~~~
    drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS' undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'?

    Selecting the option from this driver seems to solve this nicely, though I could
    not find any other instance of this in irqchip drivers.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/irqchip/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/irqchip/Kconfig
    +++ b/drivers/irqchip/Kconfig
    @@ -258,6 +258,7 @@ config IRQ_MXS

    config MVEBU_ODMI
    bool
    + select GENERIC_MSI_IRQ_DOMAIN

    config MVEBU_PIC
    bool

    \
     
     \ /
      Last update: 2017-12-18 18:33    [W:4.166 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site