Messages in this thread | | | Date | Sun, 17 Dec 2017 07:55:40 -0800 | From | Davidlohr Bueso <> | Subject | Re: [PATCH 2/2] lib: cleanup dead code from rbtree_test.c |
| |
On Sun, 17 Dec 2017, Pravin Shedge wrote:
>lib/rbtree_test.c code allows to compile either as a loadable modules or >builtin into the kernel. > >Current code returns -EAGAIN on successful termination from module_init. >Such a fail will directly unload the module and hence there is no scope >to execute rbtree_test_exit on module_exit. > >This patch will cleanup dead code from rbtree_test.c
Being completely harmless I'd rather leave this as is. If removed, the module breaks generic layout.
Thanks, Davidlohr
> >Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com> >--- > lib/rbtree_test.c | 6 ------ > 1 file changed, 6 deletions(-) > >diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c >index 7d36c1e..5cd2f26 100644 >--- a/lib/rbtree_test.c >+++ b/lib/rbtree_test.c >@@ -397,13 +397,7 @@ static int __init rbtree_test_init(void) > return -EAGAIN; /* Fail will directly unload the module */ > } > >-static void __exit rbtree_test_exit(void) >-{ >- printk(KERN_ALERT "test exit\n"); >-} >- > module_init(rbtree_test_init) >-module_exit(rbtree_test_exit) > > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Michel Lespinasse"); >-- >2.7.4 >
| |