Messages in this thread | | | From | Fabio Estevam <> | Date | Sat, 16 Dec 2017 17:32:47 -0200 | Subject | Re: [alsa-devel] [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver |
| |
Hi Tim,
On Thu, Nov 9, 2017 at 4:45 PM, Tim Harvey <tharvey@gateworks.com> wrote:
> +static int tda1997x_set_power(struct tda1997x_state *state, bool on) > +{ > + int ret = 0; > + > + if (on) { > + ret = regulator_bulk_enable(TDA1997X_NUM_SUPPLIES, > + state->supplies); > + msleep(300);
Didn't you miss a 'return ret' here?
Otherwise regulator_bulk_disable() will always be called below.
> + } > + > + ret = regulator_bulk_disable(TDA1997X_NUM_SUPPLIES, > + state->supplies); > + return ret; > +}
| |