| From | Greg Kroah-Hartman <> | Subject | [PATCH 4.4 096/105] tipc: fix memory leak in tipc_accept_from_sock() | Date | Fri, 15 Dec 2017 10:45:34 +0100 |
| |
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jon Maloy <jon.maloy@ericsson.com>
[ Upstream commit a7d5f107b4978e08eeab599ee7449af34d034053 ]
When the function tipc_accept_from_sock() fails to create an instance of struct tipc_subscriber it omits to free the already created instance of struct tipc_conn instance before it returns.
We fix that with this commit.
Reported-by: David S. Miller <davem@davemloft.net> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- net/tipc/server.c | 1 + 1 file changed, 1 insertion(+)
--- a/net/tipc/server.c +++ b/net/tipc/server.c @@ -311,6 +311,7 @@ static int tipc_accept_from_sock(struct newcon->usr_data = s->tipc_conn_new(newcon->conid); if (!newcon->usr_data) { sock_release(newsock); + conn_put(newcon); return -ENOMEM; }
|