lkml.org 
[lkml]   [2017]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments
From
Date
On 12/13/17 5:18 PM, Nicolin Chen wrote:
> - * We are running on a SoC which does not support online SSI
> - * reconfiguration, so we have to enable all necessary flags at once
> - * even if we do not use them later (capture and playback configuration)
> + * Online configuration is not supported
> + * Enable or Disable all necessary bits at once

This is an example of a bad change, IMHO. The original was written in
elegant prose. The new version is just two short sentences.

\
 
 \ /
  Last update: 2017-12-16 05:44    [W:0.103 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site