Messages in this thread | | | Date | Fri, 15 Dec 2017 23:07:41 +0100 | From | Alexandre Belloni <> | Subject | Re: [PATCH v2 07/13] dt-bindings: power: reset: Document ocelot-reset binding |
| |
On 15/12/2017 at 14:23:32 -0600, Rob Herring wrote: > On Fri, Dec 08, 2017 at 04:46:12PM +0100, Alexandre Belloni wrote: > > Add binding documentation for the Microsemi Ocelot reset block. > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: devicetree@vger.kernel.org > > Cc: Sebastian Reichel <sre@kernel.org> > > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > --- > > .../devicetree/bindings/power/reset/ocelot-reset.txt | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/power/reset/ocelot-reset.txt > > > > diff --git a/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt b/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt > > new file mode 100644 > > index 000000000000..1bcf276b04cb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt > > @@ -0,0 +1,17 @@ > > +Microsemi Ocelot reset controller > > + > > +The DEVCPU_GCB:CHIP_REGS have a SOFT_RST register that can be used to reset the > > +SoC MIPS core. > > + > > +Required Properties: > > + - compatible: "mscc,ocelot-chip-reset" > > + > > +Example: > > + syscon@71070000 { > > + compatible = "mscc,ocelot-chip-regs", "simple-mfd", "syscon"; > > + reg = <0x71070000 0x1c>; > > + > > + reset { > > + compatible = "mscc,ocelot-chip-reset"; > > Why do you need a subnode here other than as a way to instantiate a > driver? Can you describe the SOFT_RST register in reg property here > (without having overlapping regions)?
You mean like:
reset@7107001c { compatible = "mscc,ocelot-chip-reset"; reg = <0x7107001c 0x4>; };
I guess that could work.
-- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |