lkml.org 
[lkml]   [2017]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages
On Fri, 15 Dec 2017 10:36:18 +0100 Michal Hocko <mhocko@kernel.org> wrote:

> > >
> > > So do we care and I will resend the patch in that case or I just drop
> > > this from my patch queue?
> >
> > Well.. I still think that silently accepting bad input would be bad
> > practice. If we can just delete the assertion and have such a caller
> > reliably blow up later on then that's good enough.
>
> The point is that if the caller checks for the failed allocation then
> the result is a memory leak.

That's if page_address(highmem page) returns NULL. I'm not sure what
it returns, really - so many different implementations across so many
different architectures.

Oh well, it would have been nice to remove that VM_BUG_ON(). Why not
just leave the code as it is now?

\
 
 \ /
  Last update: 2017-12-15 21:58    [W:0.062 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site