Messages in this thread | | | Date | Thu, 14 Dec 2017 07:15:31 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH 04/14] ARM: dts: dra76x: Create a common file with MMC/SD IOdelay data |
| |
* Kishon Vijay Abraham I <kishon@ti.com> [171214 13:44]: > +&dra7_pmx_core { > + mmc1_pins_default: mmc1_pins_default { > + pinctrl-single,pins = < > + DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_clk.clk */ > + DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */ > + DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */ > + DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */ > + DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */ > + DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */ > + >; > + }; > + > + mmc1_pins_sdr12: mmc1_pins_sdr12 { > + pinctrl-single,pins = < > + DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_clk.clk */ > + DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */ > + DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */ > + DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */ > + DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */ > + DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */ > + >; > + };
Can't you just do:
pinctrl-0 = <&mmc1_pins_default>; pinctrl-1 = <&mmc1_pins_default>; pinctrl-2 = <&mmc1_pins_hs>; pinctrl-names = "default", "sdr12", "sdr25";
And avoid defining duplicate pinctrl groups that way?
Regards,
Tony
| |