Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Wed, 13 Dec 2017 08:23:47 +0100 | Subject | Re: [PATCH] spi: s3c64xx: add SPDX identifier |
| |
On Wed, Dec 13, 2017 at 2:48 AM, Andi Shyti <andi.shyti@samsung.com> wrote: > Hi Krzysztof, > >> > Here, this should be as a top line: >> > >> > // SPDX-License-Identifier: GPL-2.0+ >> > >> > >> > So I agree with the SPDX id but also pointing to the use of the C++ // >> > comment style as requested by Linus [1] >> >> Thanks for the reference. I see that Linus prefers converting entire >> comment into // style. I was not arguing about SPDX line but entire >> existing copyright comment which follows it: >> >> > +// >> > +// Copyright (c) 2009 Samsung Electronics Co., Ltd. >> > +// Jaswinder Singh <jassi.brar@samsung.com> > > it just looks ugly to me to have something like > > // SPDX... > > /* > * Copyright (c)... > * Jasw... > */ > > I would make everything of the '//' style (I've also seen that > this is the trend also in other subsystems), but honestly I don't > really care. If you're strong on not moving entirely in '//' style > then I can resend it with the double comment style.
Let's follow Linus' preference - entire commend converted as you did already.
Thanks, Krzysztof
| |