lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] spi: s3c64xx: add SPDX identifier
On Wed, Dec 13, 2017 at 2:48 AM, Andi Shyti <andi.shyti@samsung.com> wrote:
> Hi Krzysztof,
>
>> > Here, this should be as a top line:
>> >
>> > // SPDX-License-Identifier: GPL-2.0+
>> >
>> >
>> > So I agree with the SPDX id but also pointing to the use of the C++ //
>> > comment style as requested by Linus [1]
>>
>> Thanks for the reference. I see that Linus prefers converting entire
>> comment into // style. I was not arguing about SPDX line but entire
>> existing copyright comment which follows it:
>>
>> > +//
>> > +// Copyright (c) 2009 Samsung Electronics Co., Ltd.
>> > +// Jaswinder Singh <jassi.brar@samsung.com>
>
> it just looks ugly to me to have something like
>
> // SPDX...
>
> /*
> * Copyright (c)...
> * Jasw...
> */
>
> I would make everything of the '//' style (I've also seen that
> this is the trend also in other subsystems), but honestly I don't
> really care. If you're strong on not moving entirely in '//' style
> then I can resend it with the double comment style.

Let's follow Linus' preference - entire commend converted as you did already.

Thanks,
Krzysztof

\
 
 \ /
  Last update: 2017-12-13 08:24    [W:0.180 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site