Messages in this thread | | | Subject | Re: [PATCH] arch: define weak abort | From | Vineet Gupta <> | Date | Tue, 12 Dec 2017 10:02:51 -0800 |
| |
On 12/11/2017 01:26 PM, Sudip Mukherjee wrote: > gcc was generating abort due to 'divide by zero' and if it is not > defined in the toolchain the build fails. > > Currently 'frv' and 'arc' are failing. Previously other arch was also > broken like m32r was fixed by d22e3d69ee1a ("m32r: fix build failure"). > > Lets define this weak function which is common for all arch and fix the > problem permanently. We can even remove the arch specific 'abort' after > this is done.
Can you add some more details about the rootcause - see the corresponding ARC patch which I added before you add this generic one
http://lists.infradead.org/pipermail/linux-snps-arc/2017-December/003074.html
-Vineet
> > Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com> > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > --- > kernel/exit.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/kernel/exit.c b/kernel/exit.c > index af6c245..90c6869 100644 > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -1759,3 +1759,11 @@ long kernel_wait4(pid_t upid, int __user *stat_addr, int options, > return -EFAULT; > } > #endif > + > +__weak void abort(void) > +{ > + BUG(); > + > + /* if that doesn't kill us, halt */ > + panic("Oops failed to kill thread"); > +}
| |