lkml.org 
[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Revert "dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list"
From
Date
On 12/12/2017 02:40 PM, Cyrille Pitchen wrote:
> This reverts commit b07815d4eaf658b683c345d6e643895a20d92f29.
>
> The reverted commit was merged into v4-15-rc1 by mistake: it was taken
> from the IMX tree but the patch has never been sent to linux-mtd nor
> reviewed by any spi-nor maintainers.
>
> Actually, it would have been rejected since we add new values for the
> 'compatible' DT property only for SPI NOR memories that don't support
> the JEDEC READ ID op code (0x9F).
>
> Both en25s64 and sst25wf040b support the JEDEC READ ID op code, hence
> should use the "jedec,spi-nor" string alone as 'compatible' value.
>
> See the following link for more details:
> http://lists.infradead.org/pipermail/linux-mtd/2017-November/077425.html
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>

Acked-by: Marek Vasut <marek.vasut@gmail.com>

> ---
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> index 376fa2f50e6b..956bb046e599 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> @@ -13,7 +13,6 @@ Required properties:
> at25df321a
> at25df641
> at26df081a
> - en25s64
> mr25h128
> mr25h256
> mr25h10
> @@ -33,7 +32,6 @@ Required properties:
> s25fl008k
> s25fl064k
> sst25vf040b
> - sst25wf040b
> m25p40
> m25p80
> m25p16
>


--
Best regards,
Marek Vasut

\
 
 \ /
  Last update: 2017-12-12 17:05    [W:0.089 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site