lkml.org 
[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.14 09/60] crypto: lrw - Fix an error handling path in 'create()'
    Date
    From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 616129cc6e75fb4da6681c16c981fa82dfe5e4c7 ]

    All error handling paths 'goto err_drop_spawn' except this one.
    In order to avoid some resources leak, we should do it as well here.

    Fixes: 700cb3f5fe75 ("crypto: lrw - Convert to skcipher")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    crypto/lrw.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/crypto/lrw.c b/crypto/lrw.c
    index a8bfae4451bf..eb681e9fe574 100644
    --- a/crypto/lrw.c
    +++ b/crypto/lrw.c
    @@ -610,8 +610,10 @@ static int create(struct crypto_template *tmpl, struct rtattr **tb)
    ecb_name[len - 1] = 0;

    if (snprintf(inst->alg.base.cra_name, CRYPTO_MAX_ALG_NAME,
    - "lrw(%s)", ecb_name) >= CRYPTO_MAX_ALG_NAME)
    - return -ENAMETOOLONG;
    + "lrw(%s)", ecb_name) >= CRYPTO_MAX_ALG_NAME) {
    + err = -ENAMETOOLONG;
    + goto err_drop_spawn;
    + }
    }

    inst->alg.base.cra_flags = alg->base.cra_flags & CRYPTO_ALG_ASYNC;
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-12-13 04:04    [W:4.604 / U:0.824 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site