Messages in this thread | | | Subject | Re: [PATCH] TC: Delete an error message for a failed memory allocation in tc_bus_add_devices() | From | SF Markus Elfring <> | Date | Mon, 11 Dec 2017 14:38:52 +0100 |
| |
> However I would indeed prefer that a commit description is at least > exhaustive enough for such a dumb reviewer as I am to understand what is > going on right away.
I can follow your desire in principle.
> So please make it say at least: > > "Remove an extraneous message that duplicates the diagnostic already > provided by `kzalloc' for a memory allocation failure in this function."
How much clarification can such a wording bring to the software situation if the desired data structures might be still unclear for “the diagnostic”?
> or suchlike in v2 for me to apply a Reviewed-by: tag.
Are you interested in a safe description for a default Linux allocation failure report?
How do you think about corresponding reference documentation (besides source code)?
Regards, Markus
| |