Messages in this thread | | | Subject | Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string | From | "H. Nikolaus Schaller" <> | Date | Fri, 1 Dec 2017 10:48:38 +0100 |
| |
Hi Tomi,
> Am 01.12.2017 um 09:13 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>: > > On 01/12/17 00:06, Sebastian Reichel wrote: > >>>>> How about let's call it a "typo fix" then? :) >>>> >>>> Well, it is not really a typo. >>> >>> Well what if the stable people pick it into earlier stable series >>> based on the word fix in the subject? That has happened before. >>> >>> I suggest you update the dts patches to use wording like >>> "update compatible to use new naming" or something similar. >> >> Patch 4/4 is a Fix and should be applied to stable trees. "omapdss," >> prefix was never supposed to be in the DTS files, is not supposed to >> be in there now and will break some time in the future. >> >> Explanation: The early init of omapdss adds the prefix at runtime, >> so that the binding can use generic properties and the kernel can >> use omapdss specific drivers until the generic ones can be used > > This is true, but the extra "omapdss" does not cause any issues at the > moment, and the time when it causes issues is still many kernel versions > in the future. > > But, yes, thinking about this, I agree, it's better to pick this one > separately as a fix (after rebasing it on top of current maineline so > that it doesn't depend on the toppoly name change), and leaving the > toppoly->tpo change as a cleanup.
Just a note: there is no toppoly->tpo change for *this* panel and Pandora board. Just omapdss removal.
The GTA04 needs a toppoly->tpo change but no omapdss, removal.
So they solve different problems and are independent of each other.
GTA04: change vendor string Pandora: remove omapdss, prefix
BR and thanks, Nikolaus
| |