Messages in this thread Patch in this message | | | Date | Fri, 1 Dec 2017 11:49:58 +0200 | From | "" <> | Subject | Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts |
| |
On Mon, Nov 27, 2017 at 04:21:34PM +0000, Bernat, Yehezkel wrote: > On Mon, 2017-11-27 at 14:48 +0300, Mika Westerberg wrote: > > When ring enters polling mode we are expected to mask the ring > > interrupt > > before the callback is called. However, the current code actually > > unmasks it probably because of a copy-paste mistake. > > > > Mask the interrupt properly from now on. > > > > Fixes: 4ffe722eefcb ("thunderbolt: Add polling mode for rings") > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > --- > > drivers/thunderbolt/nhi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c > > index 419a7a90bce0..f45bcbc63738 100644 > > --- a/drivers/thunderbolt/nhi.c > > +++ b/drivers/thunderbolt/nhi.c > > @@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring > > *ring) > > return; > > > > if (ring->start_poll) { > > - __ring_interrupt_mask(ring, false); > > + __ring_interrupt_mask(ring, true); > > ring->start_poll(ring->poll_data); > > } else { > > schedule_work(&ring->work); > > Acked-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
Applied with Yehezkel's ACK.
| |