lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops
    Date
    The DSA switch VLAN ops pass the switchdev_trans structure down to the
    drivers, but no one is using them and they aren't supposed to anyway.

    Remove the trans argument from VLAN prepare and add operations.

    At the same time, fix the following checkpatch warning:

    WARNING: line over 80 characters
    #74: FILE: drivers/net/dsa/dsa_loop.c:177:
    + const struct switchdev_obj_port_vlan *vlan)

    Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
    ---
    drivers/net/dsa/b53/b53_common.c | 6 ++----
    drivers/net/dsa/b53/b53_priv.h | 6 ++----
    drivers/net/dsa/dsa_loop.c | 9 ++++-----
    drivers/net/dsa/microchip/ksz_common.c | 6 ++----
    drivers/net/dsa/mv88e6xxx/chip.c | 6 ++----
    include/net/dsa.h | 10 ++++------
    net/dsa/switch.c | 4 ++--
    7 files changed, 18 insertions(+), 29 deletions(-)

    diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
    index a7ca62ba27b7..96f8eaa8d05b 100644
    --- a/drivers/net/dsa/b53/b53_common.c
    +++ b/drivers/net/dsa/b53/b53_common.c
    @@ -1030,8 +1030,7 @@ int b53_vlan_filtering(struct dsa_switch *ds, int port, bool vlan_filtering)
    EXPORT_SYMBOL(b53_vlan_filtering);

    int b53_vlan_prepare(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans)
    + const struct switchdev_obj_port_vlan *vlan)
    {
    struct b53_device *dev = ds->priv;

    @@ -1048,8 +1047,7 @@ int b53_vlan_prepare(struct dsa_switch *ds, int port,
    EXPORT_SYMBOL(b53_vlan_prepare);

    void b53_vlan_add(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans)
    + const struct switchdev_obj_port_vlan *vlan)
    {
    struct b53_device *dev = ds->priv;
    bool untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
    diff --git a/drivers/net/dsa/b53/b53_priv.h b/drivers/net/dsa/b53/b53_priv.h
    index daaaa1ecb996..88382c5dfee4 100644
    --- a/drivers/net/dsa/b53/b53_priv.h
    +++ b/drivers/net/dsa/b53/b53_priv.h
    @@ -295,11 +295,9 @@ void b53_br_set_stp_state(struct dsa_switch *ds, int port, u8 state);
    void b53_br_fast_age(struct dsa_switch *ds, int port);
    int b53_vlan_filtering(struct dsa_switch *ds, int port, bool vlan_filtering);
    int b53_vlan_prepare(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans);
    + const struct switchdev_obj_port_vlan *vlan);
    void b53_vlan_add(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans);
    + const struct switchdev_obj_port_vlan *vlan);
    int b53_vlan_del(struct dsa_switch *ds, int port,
    const struct switchdev_obj_port_vlan *vlan);
    int b53_fdb_add(struct dsa_switch *ds, int port,
    diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
    index 3a3f4f7ba364..dcb53367f433 100644
    --- a/drivers/net/dsa/dsa_loop.c
    +++ b/drivers/net/dsa/dsa_loop.c
    @@ -173,9 +173,9 @@ static int dsa_loop_port_vlan_filtering(struct dsa_switch *ds, int port,
    return 0;
    }

    -static int dsa_loop_port_vlan_prepare(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans)
    +static int
    +dsa_loop_port_vlan_prepare(struct dsa_switch *ds, int port,
    + const struct switchdev_obj_port_vlan *vlan)
    {
    struct dsa_loop_priv *ps = ds->priv;
    struct mii_bus *bus = ps->bus;
    @@ -192,8 +192,7 @@ static int dsa_loop_port_vlan_prepare(struct dsa_switch *ds, int port,
    }

    static void dsa_loop_port_vlan_add(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans)
    + const struct switchdev_obj_port_vlan *vlan)
    {
    bool untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
    bool pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID;
    diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
    index 062a32f9ed06..53f2f17611e8 100644
    --- a/drivers/net/dsa/microchip/ksz_common.c
    +++ b/drivers/net/dsa/microchip/ksz_common.c
    @@ -558,8 +558,7 @@ static int ksz_port_vlan_filtering(struct dsa_switch *ds, int port, bool flag)
    }

    static int ksz_port_vlan_prepare(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans)
    + const struct switchdev_obj_port_vlan *vlan)
    {
    /* nothing needed */

    @@ -567,8 +566,7 @@ static int ksz_port_vlan_prepare(struct dsa_switch *ds, int port,
    }

    static void ksz_port_vlan_add(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans)
    + const struct switchdev_obj_port_vlan *vlan)
    {
    struct ksz_device *dev = ds->priv;
    u32 vlan_table[3];
    diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
    index 55026cc7e43c..b6f82d7f1841 100644
    --- a/drivers/net/dsa/mv88e6xxx/chip.c
    +++ b/drivers/net/dsa/mv88e6xxx/chip.c
    @@ -1185,8 +1185,7 @@ static int mv88e6xxx_port_vlan_filtering(struct dsa_switch *ds, int port,

    static int
    mv88e6xxx_port_vlan_prepare(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans)
    + const struct switchdev_obj_port_vlan *vlan)
    {
    struct mv88e6xxx_chip *chip = ds->priv;
    int err;
    @@ -1224,8 +1223,7 @@ static int _mv88e6xxx_port_vlan_add(struct mv88e6xxx_chip *chip, int port,
    }

    static void mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans)
    + const struct switchdev_obj_port_vlan *vlan)
    {
    struct mv88e6xxx_chip *chip = ds->priv;
    bool untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
    diff --git a/include/net/dsa.h b/include/net/dsa.h
    index d48ced87a44d..62ba1edda5f6 100644
    --- a/include/net/dsa.h
    +++ b/include/net/dsa.h
    @@ -410,12 +410,10 @@ struct dsa_switch_ops {
    */
    int (*port_vlan_filtering)(struct dsa_switch *ds, int port,
    bool vlan_filtering);
    - int (*port_vlan_prepare)(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans);
    - void (*port_vlan_add)(struct dsa_switch *ds, int port,
    - const struct switchdev_obj_port_vlan *vlan,
    - struct switchdev_trans *trans);
    + int (*port_vlan_prepare)(struct dsa_switch *ds, int port,
    + const struct switchdev_obj_port_vlan *vlan);
    + void (*port_vlan_add)(struct dsa_switch *ds, int port,
    + const struct switchdev_obj_port_vlan *vlan);
    int (*port_vlan_del)(struct dsa_switch *ds, int port,
    const struct switchdev_obj_port_vlan *vlan);
    /*
    diff --git a/net/dsa/switch.c b/net/dsa/switch.c
    index 8bfbbe408e82..233ce23b6abb 100644
    --- a/net/dsa/switch.c
    +++ b/net/dsa/switch.c
    @@ -196,14 +196,14 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,
    return -EOPNOTSUPP;

    for_each_set_bit(port, members, ds->num_ports) {
    - err = ds->ops->port_vlan_prepare(ds, port, vlan, trans);
    + err = ds->ops->port_vlan_prepare(ds, port, vlan);
    if (err)
    return err;
    }
    }

    for_each_set_bit(port, members, ds->num_ports)
    - ds->ops->port_vlan_add(ds, port, vlan, trans);
    + ds->ops->port_vlan_add(ds, port, vlan);

    return 0;
    }
    --
    2.15.0
    \
     
     \ /
      Last update: 2017-11-08 21:13    [W:3.226 / U:1.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site