Messages in this thread | | | Date | Wed, 8 Nov 2017 12:06:40 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va |
| |
On Tue, 7 Nov 2017, Joao Martins wrote: > On 11/06/2017 04:09 PM, Paolo Bonzini wrote: > > On 19/10/2017 15:39, Joao Martins wrote: > >> Right now there is only a pvclock_pvti_cpu0_va() which is defined > >> on kvmclock since: > >> > >> commit dac16fba6fc5 > >> ("x86/vdso: Get pvclock data from the vvar VMA instead of the fixmap") > >> > >> The only user of this interface so far is kvm. This commit adds a > >> setter function for the pvti page and moves pvclock_pvti_cpu0_va > >> to pvclock, which is a more generic place to have it; and would > >> allow other PV clocksources to use it, such as Xen. > >> > >> Signed-off-by: Joao Martins <joao.m.martins@oracle.com> > >> Acked-by: Andy Lutomirski <luto@kernel.org> > > > > Acked-by: Paolo Bonzini <pbonzini@redhat.com> > > > > IOW, the Xen folks are free to pick up the whole series. :) > > > Thank you! > > I guess only x86 maintainers Ack is left - any comments?
The only nit-pick I have are the convoluted function names:
pvclock_set_pvti_cpu0_va() pvclock_pvti_cpu0_va()
What on earth does that mean?
Aside of that can you please make it at least symetric, i.e. _set_ and _get_ ?
Other than that:
Acked-by: Thomas Gleixner <tglx@linutronix.de>
| |