Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH][V2] usb: gadget: pxa27x: Remove redundant assignment to is_short and dev | Date | Tue, 07 Nov 2017 19:46:53 +0100 |
| |
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com> > > Variable is_short is set to zero but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed. Pointer dev is assigned a value that > is not read and it is updated a few statements later, this too is > redundant and can be removed. Cleans up clan warnings: > > drivers/usb/gadget/udc/pxa27x_udc.c:986:3: warning: Value stored > to 'is_short' is never read > drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored > to 'dev' is never read
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
-- Robert
| |