lkml.org 
[lkml]   [2017]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] cpupowerutils: bench - Fix cpu online check
From
Date
On 11/07/2017 02:50 AM, Abhishek wrote:
> Hi,
>
> Can you please have a look at this also?
>
> Thanks and Regards,
> Abhishek Goel
> System Engineer
> IBM India Pvt. Ltd.
>

Same comment on top posting.

> On 11/07/2017 03:17 PM, Abhishek Goel wrote:
>> cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes
>> this by checking for 1 when the cpu is online.
>>
>> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
>> ---
>> v2: Commit message rephrased.
>> ---
>>   tools/power/cpupower/bench/system.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
>> index c25a74a..2bb3eef 100644
>> --- a/tools/power/cpupower/bench/system.c
>> +++ b/tools/power/cpupower/bench/system.c
>> @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
>>
>>       dprintf("set %s as cpufreq governor\n", governor);
>>
>> -    if (cpupower_is_cpu_online(cpu) != 0) {
>> +    if (cpupower_is_cpu_online(cpu) != 1) {
>>           perror("cpufreq_cpu_exists");
>>           fprintf(stderr, "error: cpu %u does not exist\n", cpu);
>>           return -1;
>

Ths patch looks good to me. I still need it in my Inbox. Please send it
to me directly.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2017-11-08 21:07    [W:0.052 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site