lkml.org 
[lkml]   [2017]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kbuild: Set KBUILD_CFLAGS before incl. arch Makefile
On Sat, Nov 4, 2017 at 8:06 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> ld-option is only used for arch/{arm64,powerpc}/Makefile
>
> arch/arm64/Makefile: ifeq ($(call ld-option, --fix-cortex-a53-843419),)
> arch/powerpc/Makefile:LDFLAGS_vmlinux += $(call
> ld-option,--orphan-handling=warn)
>
> I think this patch makes sense when it comes along with
> https://patchwork.kernel.org/patch/10030581/

Good point.

> but, it is now being blocked by 0-day bot
> due to a x86 problem.

Looks like that is now resolved (unless 0-day bot strikes again).

> The location of CLANG_GCC_TC define
> only matters after your patch is applied, right?

By "your patch" referring to the 0-day bot thread, yes.

> Did my request for v2 break anything?

Nothing immediately obvious, and no regressions. It just made this
patch necessary (along with my previous one) for correctly cross
compiling with clang for arm64 and powerpc as you point out.

> One more thing: this patch does not apply to kbuild tree.

I absolutely will rebase it on your tree and send a v2. Just to help
me understand the contribution model better: none of my other patches
have yet been requested against any trees other than Linus'. Is this
because of where we are in the release cycle, or that a lot of kbuild
code has changed, or what?

\
 
 \ /
  Last update: 2017-11-08 21:06    [W:0.143 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site