Messages in this thread | | | Date | Tue, 7 Nov 2017 09:24:29 -0800 | From | Andi Kleen <> | Subject | Re: [PATCH] perf/core: fast breakpoint modification via _IOC_MODIFY_BREAKPOINT. |
| |
On Tue, Nov 07, 2017 at 07:43:35AM -0800, Milind Chabbi wrote: > Peter, > > Generic update perf_event_attr interface is noble but impractical. > It will cause a validation nightmare. > Many of the behaviors or choices will become hard to reason.
I don't think you would necessarily need to support modifying all of this. Just define a general interface that could be used to modify these things, but right now it would be only implemented for the special case of breakpoints.
Your ioctl is very near it anyways, just need to change the name and do more sanity checking on the input values.
-Andi
| |