lkml.org 
[lkml]   [2017]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tty: serial: jsm: remove redundant pointer ts
From
Date
On 11/07/2017 09:41 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer ts is assigned a value that is never read, ts is therefore
> redundant and can be removed. Cleans up clang warning:
>
> drivers/tty/serial/jsm/jsm_tty.c:285:2: warning: Value stored to 'ts'
> is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks Colin!

Acked-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>


> ---
> drivers/tty/serial/jsm/jsm_tty.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
> index e69227cc3827..5ecd878669b8 100644
> --- a/drivers/tty/serial/jsm/jsm_tty.c
> +++ b/drivers/tty/serial/jsm/jsm_tty.c
> @@ -275,14 +275,12 @@ static int jsm_tty_open(struct uart_port *port)
> static void jsm_tty_close(struct uart_port *port)
> {
> struct jsm_board *bd;
> - struct ktermios *ts;
> struct jsm_channel *channel =
> container_of(port, struct jsm_channel, uart_port);
>
> jsm_dbg(CLOSE, &channel->ch_bd->pci_dev, "start\n");
>
> bd = channel->ch_bd;
> - ts = &port->state->port.tty->termios;
>
> channel->ch_flags &= ~(CH_STOPI);
>

\
 
 \ /
  Last update: 2017-11-08 21:05    [W:0.040 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site