Messages in this thread Patch in this message | | | Date | Tue, 7 Nov 2017 03:15:14 -0800 | From | tip-bot for Masami Hiramatsu <> | Subject | [tip:perf/kprobes] arm/kprobes: Fix kretprobe test to check correct counter |
| |
Commit-ID: 4650209b166789182657c8eb0612cecd5b54d591 Gitweb: https://git.kernel.org/tip/4650209b166789182657c8eb0612cecd5b54d591 Author: Masami Hiramatsu <mhiramat@kernel.org> AuthorDate: Sat, 4 Nov 2017 13:30:52 +0900 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Tue, 7 Nov 2017 11:25:14 +0100
arm/kprobes: Fix kretprobe test to check correct counter
test_kretprobe() uses jprobe_func_called at the last test, but it must check kretprobe_handler_called.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Jon Medhurst <tixy@linaro.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mark Brown <broonie@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Russell King <linux@armlinux.org.uk> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Wang Nan <wangnan0@huawei.com> Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/150976985182.2012.15495311380682779381.stgit@devbox Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/arm/probes/kprobes/test-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c index 1c98a87..9c3ceba 100644 --- a/arch/arm/probes/kprobes/test-core.c +++ b/arch/arm/probes/kprobes/test-core.c @@ -451,7 +451,7 @@ static int test_kretprobe(long (*func)(long, long)) } if (!call_test_func(func, false)) return -EINVAL; - if (jprobe_func_called == test_func_instance) { + if (kretprobe_handler_called == test_func_instance) { pr_err("FAIL: kretprobe called after unregistering\n"); return -EINVAL; }
| |