Messages in this thread | | | Subject | Re: [Part2 PATCH v7 20/38] crypto: ccp: Implement SEV_PDH_CERT_EXPORT ioctl command | From | Brijesh Singh <> | Date | Mon, 6 Nov 2017 10:16:53 -0600 |
| |
On 11/05/2017 05:34 AM, Borislav Petkov wrote: ...
> > Fixes ontop: > > * !input.cert_chain_address test was repeated. I saw that by aligning > them vertically, i.e., after making it more readable, the repetition > became obvious. > > * Do the lengths checks first and the access_ok after, in each PDH and > cert chain test. > > * Do the checks first and the allocations after, not interleaved. > > * Comments are sentences which should end with a '.' > > (hunk below contains also that &psp_master->cmd_buf change but you're going to > remove that arg anyway). >
I am good with all your fixup, I will apply them in v8.
-Brijesh
| |