lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v10 20/38] x86, mpparse: Use memremap to map the mpf and mpc data
    On 3 November 2017 at 16:31, Tom Lendacky <thomas.lendacky@amd.com> wrote:
    > On 11/3/2017 10:12 AM, Tomeu Vizoso wrote:
    >>
    >> On 17 July 2017 at 23:10, Tom Lendacky <thomas.lendacky@amd.com> wrote:
    >>>
    >>> The SMP MP-table is built by UEFI and placed in memory in a decrypted
    >>> state. These tables are accessed using a mix of early_memremap(),
    >>> early_memunmap(), phys_to_virt() and virt_to_phys(). Change all accesses
    >>> to use early_memremap()/early_memunmap(). This allows for proper setting
    >>> of the encryption mask so that the data can be successfully accessed when
    >>> SME is active.
    >>>
    >>> Reviewed-by: Borislav Petkov <bp@suse.de>
    >>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
    >>> ---
    >>> arch/x86/kernel/mpparse.c | 98
    >>> +++++++++++++++++++++++++++++++++--------------
    >>> 1 file changed, 70 insertions(+), 28 deletions(-)
    >>
    >>
    >> Hi there,
    >>
    >> today I played a bit with crosvm [0] and noticed that 4.14-rc7 doesn't
    >> boot. git-bisect pointed to this patch, and reverting it indeed gets
    >> things working again.
    >>
    >> Anybody has an idea of why this could be?
    >
    >
    > If you send me your kernel config I'll see if I can reproduce the issue
    > and debug it.

    x86_64_defconfig should be enough. I have pasted my dev env
    instructions here in case they help:

    http://blog.tomeuvizoso.net/2017/11/experiments-with-crosvm_6.html

    Thanks,

    Tomeu

    \
     
     \ /
      Last update: 2017-11-06 08:14    [W:4.056 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site