Messages in this thread Patch in this message | | | Date | Mon, 6 Nov 2017 18:52:03 +0800 | From | "Liu, Changcheng" <> | Subject | Re: [PATCH 0001/0001] format idle IP output func+offset/length |
| |
kaslr feature is enabled in kernel. Remove kernel text address when dumping idle IP info
Signed-off-by: Liu Changcheng <changcheng.liu@intel.com> Signed-off-by: Jerry Liu <primerlink@gmail.com>
diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c index 0bc0a35..9cc4178 100644 --- a/lib/nmi_backtrace.c +++ b/lib/nmi_backtrace.c @@ -92,7 +92,7 @@ bool nmi_cpu_backtrace(struct pt_regs *regs) if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) { arch_spin_lock(&lock); if (regs && cpu_in_idle(instruction_pointer(regs))) { - pr_warn("NMI backtrace for cpu %d skipped: idling at pc %#lx\n", + pr_warn("NMI backtrace for cpu %d skipped: idling at %pS\n", cpu, instruction_pointer(regs)); } else { pr_warn("NMI backtrace for cpu %d\n", cpu); -- 2.7.4 On 17:05 Mon 06 Nov, Sergey Senozhatsky wrote: > On (11/06/17 13:25), Liu, Changcheng wrote: > > kaslr feature is enabled in kernel. > > Remove kernel text address when dumping idle IP info > > > > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com> > > Signed-off-by: Jerry Liu <primerlink@gmail.com> > > > > diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c > > index 0bc0a35..9cc4178 100644 > > --- a/lib/nmi_backtrace.c > > +++ b/lib/nmi_backtrace.c > > @@ -92,7 +92,7 @@ bool nmi_cpu_backtrace(struct pt_regs *regs) > > if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) { > > arch_spin_lock(&lock); > > if (regs && cpu_in_idle(instruction_pointer(regs))) { > > - pr_warn("NMI backtrace for cpu %d skipped: idling at pc %#lx\n", > > + pr_warn("NMI backtrace for cpu %d skipped: idling at pc %pS\n", > I guess the word 'pc' can be dropped from the message ^^ > > there seems to be other cases in the kernel when we print regs->pc/regs->ip. > > -ss > > > cpu, instruction_pointer(regs)); > > } else { > > pr_warn("NMI backtrace for cpu %d\n", cpu);
| |