Messages in this thread | | | Date | Tue, 7 Nov 2017 13:40:49 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH 1/2] printk: Relocate wake_klogd check close to the end of console_unlock() |
| |
On (11/02/17 06:51), Tejun Heo wrote: > We mark for waking up klogd whenever we see a new message sequence in > the main loop. However, the actual wakeup is always at the end of the > function and we can easily test for the wakeup condition when we do > the final should-we-repeat check. > > Move the wake_klogd condition check out of the main loop. This avoids > doing the same thing repeatedly and groups similar checks into a > common place. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Petr Mladek <pmladek@suse.com> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > Cc: Steven Rostedt <rostedt@goodmis.org>
looks good to me.
FWIW,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
| |