lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 037/294] ARM: kexec: Make .text R/W in machine_kexec
    3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nikolay Borisov <Nikolay.Borisov@arm.com>

    commit 42d720d1731a9d7035c2812437c35e271ec4dd78 upstream.

    With the introduction of Kees Cook's patch to make the kernel .text
    read-only the existing method by which kexec works got broken since it
    directly pokes some values in the template code, which resides in the
    .text section.

    The current patch changes the way those values are inserted so that poking
    .text section occurs only in machine_kexec (e.g when we are about to nuke
    the old kernel and are beyond the point of return). This allows to use
    set_kernel_text_rw() to directly patch the values in the .text section.

    I had already sent a patch which achieved this but it was significantly
    more complicated, so this is a cleaner/straight-forward approach.

    Signed-off-by: Nikolay Borisov <Nikolay.Borisov@arm.com>
    Acked-by: Will Deacon <will.deacon@arm.com>
    [kees: collapsed kexec_boot_atags (will.daecon)]
    [kees: for bisectability, moved set_kernel_text_rw() to RODATA patch]
    Signed-off-by: Kees Cook <keescook@chromium.org>
    Acked-by: Nicolas Pitre <nico@linaro.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/arm/kernel/machine_kexec.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/arch/arm/kernel/machine_kexec.c
    +++ b/arch/arm/kernel/machine_kexec.c
    @@ -29,6 +29,7 @@ extern unsigned long kexec_boot_atags;

    static atomic_t waiting_for_crash_ipi;

    +static unsigned long dt_mem;
    /*
    * Provide a dummy crash_notes definition while crash dump arrives to arm.
    * This prevents breakage of crash_notes attribute in kernel/ksysfs.c.
    @@ -64,7 +65,7 @@ int machine_kexec_prepare(struct kimage
    return err;

    if (be32_to_cpu(header) == OF_DT_HEADER)
    - kexec_boot_atags = current_segment->mem;
    + dt_mem = current_segment->mem;
    }
    return 0;
    }
    @@ -166,9 +167,8 @@ void machine_kexec(struct kimage *image)
    kexec_start_address = image->start;
    kexec_indirection_page = page_list;
    kexec_mach_type = machine_arch_type;
    - if (!kexec_boot_atags)
    - kexec_boot_atags = image->start - KEXEC_ARM_ZIMAGE_OFFSET + KEXEC_ARM_ATAGS_OFFSET;
    -
    + kexec_boot_atags = dt_mem ?: image->start - KEXEC_ARM_ZIMAGE_OFFSET
    + + KEXEC_ARM_ATAGS_OFFSET;

    /* copy our kernel relocation code to the control code page */
    reboot_entry = fncpy(reboot_code_buffer,
    \
     
     \ /
      Last update: 2017-11-08 20:59    [W:4.062 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site