lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 120/294] netxen: fix incorrect loop counter decrement
    3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit a120d9ab65354727559b9db75ded8071b7ef19e2 upstream.

    The loop counter k is currently being decremented from zero which
    is incorrect. Fix this by incrementing k instead

    Detected by CoverityScan, CID#401847 ("Infinite loop")

    Fixes: 83f18a557c6d ("netxen_nic: fw dump support")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
    +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
    @@ -2332,7 +2332,7 @@ netxen_md_rdqueue(struct netxen_adapter
    loop_cnt++) {
    NX_WR_DUMP_REG(select_addr, adapter->ahw.pci_base0, queue_id);
    read_addr = queueEntry->read_addr;
    - for (k = 0; k < read_cnt; k--) {
    + for (k = 0; k < read_cnt; k++) {
    NX_RD_DUMP_REG(read_addr, adapter->ahw.pci_base0,
    &read_value);
    *data_buff++ = read_value;
    \
     
     \ /
      Last update: 2017-11-08 20:58    [W:4.126 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site