Messages in this thread | | | Date | Mon, 6 Nov 2017 18:23:25 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() |
| |
> PCI: remove unused __weak attribute in pci_register_io_range()
Please capitalize to follow drivers/pci convention, e.g.,
PCI: Remove __weak attribute from pci_register_io_range()
(Also do the same for the other PCI patches.)
On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > From: gabriele paoloni <gabriele.paoloni@huawei.com> > > Currently pci_register_io_range() has only one definition; > therefore there is no use of the __weak attribute. > > Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Acked-by: Bjorn Helgaas <helgaas@kernel.org> > --- > drivers/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index af0cc34..eee967c 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > * Record the PCI IO range (expressed as CPU physical address + size). > * Return a negative value if an error has occured, zero otherwise > */ > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size) > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > { > int err = 0; > > -- > 2.7.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |