lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 030/294] usb: renesas_usbhs: fix usbhsc_resume() for !USBHSF_RUNTIME_PWCTRL
    3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

    commit 59a0879a0e17b2e43ecdc5e3299da85b8410d7ce upstream.

    This patch fixes an issue that some registers may be not initialized
    after resume if the USBHSF_RUNTIME_PWCTRL is not set. Otherwise,
    if a cable is not connected, the driver will not enable INTENB0.VBSE
    after resume. And then, the driver cannot detect the VBUS.

    Fixes: ca8a282a5373 ("usb: gadget: renesas_usbhs: add suspend/resume support")
    Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/renesas_usbhs/common.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/usb/renesas_usbhs/common.c
    +++ b/drivers/usb/renesas_usbhs/common.c
    @@ -600,8 +600,10 @@ static int usbhsc_resume(struct device *
    struct usbhs_priv *priv = dev_get_drvdata(dev);
    struct platform_device *pdev = usbhs_priv_to_pdev(priv);

    - if (!usbhsc_flags_has(priv, USBHSF_RUNTIME_PWCTRL))
    + if (!usbhsc_flags_has(priv, USBHSF_RUNTIME_PWCTRL)) {
    usbhsc_power_ctrl(priv, 1);
    + usbhs_mod_autonomy_mode(priv);
    + }

    usbhs_platform_call(priv, phy_reset, pdev);

    \
     
     \ /
      Last update: 2017-11-08 20:58    [W:4.181 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site