Messages in this thread | | | Date | Sun, 5 Nov 2017 07:13:35 -0800 | From | Guenter Roeck <> | Subject | Re: watchdog: wdt_pci: mark expected switch fall-through |
| |
On Fri, Nov 03, 2017 at 06:07:23PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "Fall" with a proper > "fall through" comment, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/wdt_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c > index bc7addc..10e2cda0 100644 > --- a/drivers/watchdog/wdt_pci.c > +++ b/drivers/watchdog/wdt_pci.c > @@ -430,7 +430,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd, > if (wdtpci_set_heartbeat(new_heartbeat)) > return -EINVAL; > wdtpci_ping(); > - /* Fall */ > + /* fall through */ > case WDIOC_GETTIMEOUT: > return put_user(heartbeat, p); > default:
| |