lkml.org 
[lkml]   [2017]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: sched: cls_u32: use bitwise & rather than logical && on n->flags
From
From: Colin King <colin.king@canonical.com>
Date: Fri, 3 Nov 2017 08:09:45 +0000

> From: Colin Ian King <colin.king@canonical.com>
>
> Currently n->flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
>
> Detected by CoverityScan, CID#1460398 ("Logical vs. bitwise operator")
>
> Fixes: 245dc5121a9b ("net: sched: cls_u32: call block callbacks for offload")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks Colin.

\
 
 \ /
  Last update: 2017-11-04 14:52    [W:0.035 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site