Messages in this thread | | | Date | Sat, 4 Nov 2017 11:40:10 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/ |
| |
On Fri, Nov 03, 2017 at 05:53:01PM +0100, Johan Hovold wrote: > On Fri, Nov 03, 2017 at 11:28:30AM +0100, Greg Kroah-Hartman wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/usb/ and include/linux/usb* files with the correct > > SPDX license identifier based on the license text in the file itself. > > The SPDX identifier is a legally binding shorthand, which can be used > > instead of the full boiler plate text. > > > > This work is based on a script and data from Thomas Gleixner, Philippe > > Ombredanne, and Kate Stewart. > > > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Kate Stewart <kstewart@linuxfoundation.org> > > Cc: Philippe Ombredanne <pombredanne@nexb.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > For USB serial: > > Acked-by: Johan Hovold <johan@kernel.org>
Great, thanks for the ack.
> I noticed several MODULE_LICENSE macros which did not match the headers > (e.g. "GPL" being used for version 2 only modules) for which I'll send a > follow-up patch. > > Someone should probably write a script for that once the SPDX > identifiers are in.
Yes, I think that someone might have a script for that, it will be much easier to detect these things now. The issue is that the "v2" marking came after the original "GPL" marking for MODULE_LICENSE() from what I remember, so many of those will be wrong.
thanks,
greg k-h
| |